Adding to an array of strings - C/C++

Sh3llc0d3

Ok guys need help, I've got an array of strings, thing is I'm trying to add to it. I can't work out how it'd be done. My books tell me how to add to plain strings using strcat(str1, str2) I believe. Is there anyway anyone can help me with this? I've got so far, listing how to search for a password in the array using a strcmp statement for the name of the user. I want to add a function so the user can input a new user and password into the array. But like I said I can't work out how, can anyone help?

#include &lt;iostream&gt;
#include &lt;cstdio&gt;

int main()
{
	using std&#58;&#58;cout;
	using std&#58;&#58;cin;
	using std&#58;&#58;endl;
	
	int i;
	char str&#91;80&#93;;
	char users&#91;10&#93;&#91;80&#93; = 
	{
		\"tom\", \"pass1\",
		\"tim\", \"pass2\"
	};
	
	cout &lt;&lt; \"Enter name&#58; \";
	cin &gt;&gt; str;
	
	for(i=0; i&lt;10;i+=2)
		if(!strcmp(str, numbers&#91;i&#93;))
		{
			cout &lt;&lt; \"Passowrd is \" &lt;&lt; users&#91;i+1&#93; &lt;&lt; endl;
			break;
		}
	if(i == 10) cout &lt;&lt; \"Not found&#46;\n\";
	
	return 0;
}

chroniccommand

Shit. If it were C I'd be able to help you out. Unfortunately I don't know C++

CustomiZer

WTF :S
The program is all fucked up. You have not declared number array, yet you use it.

But could you elaborate what you (or this program) are trying to do. I would help you sort it out once you explain the problem properly to me.

Sh3llc0d3

said:

WTF :S
The program is all fucked up. You have not declared number array, yet you use it.

But could you elaborate what you (or this program) are trying to do. I would help you sort it out once you explain the problem properly to me.

Well at the time I was trying to make a c++ user list complete with passwords. I thought "char users[10][80]" was declaring the array... I then go to define what is in the array as user1 then pass 1 then next line in the array user 2 then pass2 etc all the way to 10 for each.(excuse my memory)

I wanted to add to this program using an add function extra user's and alter passwords. That was the point of it. And this code was screwed up because I had a concept in my head after looking up arrays and learning a bit about them and couldn't put it down as I visualised it happening.

sangf

megabump! i know you most likely don't need an explanation now, but i figured i would give the thread a bit of closure.

i'm not surprised you were having trouble with this, arrays in C are pretty complex, which is not helped by the fact that many tutorials only cover basic static arrays - dynamic arrays (the most logicially useful type of array) are a different ballgame. well, maybe if ballgames were completely frustrating and confusing.. and played without balls.. /badjoke.

however, in C++ the STL makes it much easier for us. what you had in that sample is psuedo C/C++, which is still ok.. but unneccesarily complicated, moreso if you want to get something done in code than to learn (dynamic char arrays are a great way to learn about memory management.. how things are stored, etc.).

if you don't mind using the static array like you already declared, it can actually be quite simple using functions from the C string function family you already mentioned (strcmp/strcat/etc).


char users&#91;10&#93;&#91;10&#93; =
{
    \"tom\", \"pass1\",
    \"tim\", \"pass2\"
};

how this is actually represented in memory, where $ is the null string terminator (identifies where the string ends - usually represented by \0 which is the escape sequence in C/C++):


&#46;  0  1  2  3  4  5  6  7  8  9
0 &#91;t&#93;&#91;o&#93;&#91;m&#93;&#91;$&#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;
1 &#91;p&#93;&#91;a&#93;&#91;s&#93;&#91;s&#93;&#91;1&#93;&#91;$&#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;
2 &#91;t&#93;&#91;i&#93;&#91;m&#93;&#91;$&#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;
3 &#91;p&#93;&#91;a&#93;&#91;s&#93;&#91;s&#93;&#91;2&#93;&#91;$&#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;
4 &#91;$&#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;
5 &#91;$&#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;
6 &#91;$&#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;
7 &#91;$&#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;
8 &#91;$&#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;
9 &#91;$&#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;&#91; &#93;
be careful, we're almost entering the matrix
p&#46;s&#46; note; probably a good idea to think of this flipped on the axis (my bad)

so, as you can see there are plenty of places to insert new data. if it's acceptable to specify the size of your array like this and fill the data in using what you have, you can see the below example and description for a pointer in the right direction.



// initialize 2d char array (users&#91;0&#93;, users&#91;1&#93;, users&#91;2&#93;, users&#91;3&#93; = tom\0, pass1\0, tim\0, pass2\0)
char users&#91;10&#93;&#91;10&#93; =
{
    \"tom\", \"pass1\",
    \"tim\", \"pass2\"
};

// strcpy() copies the string \"tam\" to the array (at 4,0+ on the grid example)
// users&#91;4&#93; is actually a pointer to the first character of the second dimension of the array - the string is determined by everything between that pointer('s pointee) and the null terminator&#46;
// so in fact, strcpy() copies the string \"tam\" from anywhere users&#91;4&#93; points to, to 10-1 (80-1 in yours) sizeof(char)s later (ie&#46; be careful because if the string you copy contains more data than that&#46;&#46; well, buffer overflow)&#46;
strcpy(users&#91;4&#93;, \"tam\");

// print the array to test it worked! (we might as well use printf since it's mostly C code anyway, but oh well&#46;
for (int i = 0; i &lt; sizeof(users)/sizeof(users&#91;0&#93;); i++)
{
    if (users&#91;i&#93;&#91;0&#93; != '\0') cout &lt;&lt; users&#91;i&#93; &lt;&lt; endl;
}

and if that's no good to you, you can either learn about dynamic memory allocation functions in C (malloc, realloc, calloc, etc.) and create your own dynamic array structure/functions. or you can go the C++ route and make use of std::string and std::vector, which i promise is much cleaner to deal with. i've just included a simple sample below which demonstrates its use, there are good STL resources online which you can read to understand further.


#include &lt;iostream&gt;
#include &lt;string&gt;
#include &lt;vector&gt;

using namespace std;

int main()
{
    // declare new vector of strings
    vector &lt;string&gt; users;

    // use push_back() to add a string to the vector (dynamic resizing is done for you)
    // ugly initializing list of values&#58; commence
    users&#46;push_back(\"tom\");
    users&#46;push_back(\"pass1\");
    users&#46;push_back(\"tim\");
    users&#46;push_back(\"pass2\");

    cout &lt;&lt; \"Enter additional user to be added to the vector&#58; \";
    string additional_user;
    cin &gt;&gt; additional_user;
    users&#46;push_back(additional_user);

    for (unsigned int i = 0; i &lt; users&#46;size(); i++)
        cout &lt;&lt; users&#91;i&#93; &lt;&lt; endl; // or users&#46;at(i)

    return 0;
}

note: feel free to bitch about things that might be wrong or need correcting and i'll update it with relevant info.

Sh3llc0d3

Fuck me. I wasn't expecting that. I understand the basic concepts of the memory allocation in arrays you mentioned in your very nice diagram by the way :P lol. At the time I had little experience working with arrays, however since working with arrays in other languages I understand a lot more than I did back then :)

If I remember rightly at the time I was struggling between whether using strcpy to add to the next line in the array or 'append' if thats the right word with strcat. Something random like that.

Thanks so much for the reply though, wait till next time you tell me you only know a bit of C++!! :)

sangf

said:

Fuck me. I wasn't expecting that. I understand the basic concepts of the memory allocation in arrays you mentioned in your very nice diagram by the way :P lol.

thanks lol.

and yeah, strcat() would work for empty strings, but it's really for appending strings (cat -> concatanate), so strcat(users[0], "tom"); would actually append "tom" to the string that already had "tom" -> "tomtom". both functions actually take a char pointer as their copy/overwrite destination; so just a pointer to the first character, from there strcpy() straight out copies characters to the right of that point till \0 (not that memory have directions, lol but yeah..) while strcat() goes up to the \0, overwrites it following with whatever, and adds a new \0. both do no checking and can easily crash (buffer overflow) iirc.

what's more interesting is why we are still awake! :p

Sh3llc0d3

It's 7 am. I spent the best part of 3/4hrs trying to sort that script out and cannot for the life of me work out where I'm going wrong. I need sleep but really getting past the point of tiredness lol.

Again, great explanation :)

sangf

I need sleep but really getting past the point of tiredness lol.

haha, that's the kind of thing that turns my mornings to nights ;)

Howdy, Stranger!

Top Posters

Who's Online (1)